chore(ios) : Updated ios module’s version to latest #10870
Conversation
|
support/module/packaged/modules.json
Outdated
| }, | ||
| "ti.safaridialog": { | ||
| "url": "https://github.com/appcelerator-modules/ti.safaridialog/releases/download/iOS-1.1.1/ti.safaridialog-iphone-1.1.1.zip", | ||
| "integrity": "sha512-6g3Qi9RUCl3uf06OnrThm9fpxhcxhtRzyoFRE5PJpenTFN45QYGRZeEQAqgTKcvEB0ardUfGMOyZcA8WoCfWTw==" | ||
| "url": "https://github.com/appcelerator-modules/ti.safaridialog/releases/download/iOS-2.0.0/ti.safaridialog-iphone-2.0.0.zip", |
There was a problem hiding this comment.
Can we include a new major of a module in 8.1.0?
There was a problem hiding this comment.
Modules have their own release cycle, other than sdk. So I think it should not be a problem including major of module in 8.1.0. @mukherjee2 @lokeshchdhry ?
There was a problem hiding this comment.
@vijaysingh-axway By default we always use the latest version of a module of no explicit version is specified in tiapp.xml. Now, if the ti.safaridialog module contains a breaking API change this will break existing projects.
@ewanharris already opened a ticket for this issue, i just can't find it right now.
There was a problem hiding this comment.
@ewanharris @janvennemann Restored ti.safaridialog to non-major version.
|
@vijaysingh-axway ti.safaridialog module still has the version 1.1.1 with the PR's SDK. Not getting the Latest version. Can you please look at it |
@keerthi1032 ti.safaridialog has major release version 2.0.0. So that will be included in SDK's Major release. |
|
|
|
FR passed. Latest version updated for default modules on iOS side. Test Environment: |
* chore(android): bump ti.playservices to 16.1.3 * fix: fix download method and cleanup modules-integrity * chore(android): update ti.playservices hash * chore(ios) : Updated ios module’s version to latest * fix(ios) : ti.safaridialog restored to non-major version as per review comment.
https://jira.appcelerator.org/browse/TIMOB-27047
Note - Merge #10867 first