Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): APK signing will fail when using MD5 keystore and JDK 8+ #10888

Merged
merged 3 commits into from May 17, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented May 15, 2019

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26895


MD5 Keystore Test:

  1. Follow the test procedure documented in TIMOB-26895.
  2. Verify that an APK was successfully built with that ticket's testmd5.keystore.

SHA256 Keystore Test:

  1. Copy the testsha256.keystore from TIMOB-26895 to the root directory of your project.
  2. In Appc Studio, select "Package" from the top-left-most dropdown box.
  3. In Appc Studio, select "Android Play Store" from the other dropdown box.
  4. Click the build button.
  5. For "Keystore Location", click the "Browse" button and select the testsha256.keystore file.
  6. For "Keystore Password", enter: testsha256
  7. For "Keypair Password", enter: testsha256
  8. For "Key Alias", enter: testsha256
  9. Click the "Publish" button.
  10. Verify that an APK was successfully built.

@jquick-axway jquick-axway added this to the 8.1.0 milestone May 15, 2019
@jquick-axway jquick-axway requested a review from ypbnv May 15, 2019 03:43
@jquick-axway jquick-axway changed the title fix(android): Fixed issue where APK signing will fail when using MD5 keystore and JDK 8+ fix(android): APK signing will fail when using MD5 keystore and JDK 8+ May 15, 2019
@build
Copy link
Contributor

build commented May 15, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3727 tests are passing.
(There are 467 tests skipped)

Generated by 🚫 dangerJS against 8a24496

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@keerthi1032
Copy link
Contributor

FR passed. Apk built successfully with MD5,SHA256,SHA1 keystone.

Test Environment:
Operating System
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local sdk 8.1.0.v20190515105948
CLI =7.0.11
Studio =5.1.2.201903111843

@keerthi1032 keerthi1032 merged commit 3a97e59 into tidev:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants