New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(process): load ENV variables into process.env #10895
Conversation
|
For QE testing: run a build with something like:
And an app.js with: Ti.API.info(process.env.MY_ENV_VAR); It should print out "testing" in the log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed Able to load ENV variables into process.env.
Test Steps:
- Created a new Titanium application with the build from this PR
- Added the following in to the app.js:
Ti.API.info(process.env.MY_ENV_VAR);
- Ran the following command:
MY_ENV_VAR=testing ti build -p ios
- Able to see the following in the console:
[INFO] testing
Test Environment
iPhone 6S plus (12.2 Sim)
APPC CLI: 7.0.12-70X.4
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.11.3
Xcode 10.2.1
I think this pull request broke incremental builds. Can someone confirm? I noticed full rebuilds on every incremental build since last week. It can also be #10805 but I think it worked fine with that one. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27045
Description: