Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-6844 (1_8_X): Android: UI - hardware button events not fired for heavyweight windows in tabGroups #1090

Merged
merged 1 commit into from Dec 22, 2011
Merged

TIMOB-6844 (1_8_X): Android: UI - hardware button events not fired for heavyweight windows in tabGroups #1090

merged 1 commit into from Dec 22, 2011

Conversation

marshall
Copy link
Contributor

@marshall
correctly associate tab activities with their window proxy
b5663ce 
after the activity is created, restoring android event listeners
for tab windows. TIMOB-6844
@rusticphilosopher
Copy link
Contributor

Code reviewed. Functional test passed. accepted

@hieupham007
Copy link
Contributor

Code review accepted

@eric34
Copy link
Contributor

eric34 commented Dec 22, 2011

Pull accepted:
Verified app shows back button event, volume down event, and search event in v8 and Rhino on:
Nexus s (2.3.6)
Droid 1 (2.2.2)
Droid 3 (2.3.4)
LG Slate (3.1) (Verified back and volume, no search - all soft buttons)

ayeung pushed a commit that referenced this pull request Dec 22, 2011
Merge pull request #1090 from marshall/timob-6844-1_8_X
fbdc96f 
TIMOB-6844 (1_8_X): Android: UI - hardware button events not fired for heavyweight windows in tabGroups
@ayeung ayeung merged commit fbdc96f into tidev:1_8_X Dec 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marshall @rusticphilosopher @hieupham007 @eric34 @ayeung