fix(ios): exclude all frameworks from optimizing files step #10905
Conversation
iphone/cli/commands/_build.js
Outdated
| @@ -6495,7 +6495,7 @@ iOSBuilder.prototype.optimizeFiles = function optimizeFiles(next) { | |||
| } | |||
| } | |||
| }); | |||
| }(this.xcodeAppDir, /^(PlugIns|Watch|TitaniumKit\.framework)$/i)); | |||
| }(this.xcodeAppDir, /^(PlugIns|Watch|\.framework)$/i)); | |||
There was a problem hiding this comment.
Do you mean /^(PlugIns|Watch|.+\.framework)$/i?
There was a problem hiding this comment.
Oh yeah sure, didn't notice the ^ at the beginning of the regex.
| @@ -579,7 +579,7 @@ class FrameworkIntegrator { | |||
| isa: 'PBXBuildFile', | |||
| fileRef: fileRefUuid, | |||
| fileRef_comment: frameworkPackageName, | |||
| settings: { ATTRIBUTES: [ 'CodeSignOnCopy' ] } | |||
| settings: { ATTRIBUTES: [ 'CodeSignOnCopy', 'RemoveHeadersOnCopy' ] } | |||
There was a problem hiding this comment.
I believe Xcode would automatically add RemoveHeadersOnCopy when you opened the generated Xcode project. I tested explicitly adding it as you've done, but as I recall it wasn't necessary, so I ripped it out. I'm fine with you adding it.
There was a problem hiding this comment.
Just tested this pull - it works fine without this setting.
There was a problem hiding this comment.
I just added it for consistency because that's the attributes we use when adding TitaniumKit as well.
|
|
@cb1kenobi ping! Can you give this another look? Thanks! |
janvennemann
changed the title
|
FR Passed. The project with a framework having png/plist files builds successfully each time. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27097
Optional Description:
If a framework contains .png or .plist files our build will try to optimize those. Xcode will update code signing on the first build but fails to do so on subsequent builds. Frameworks should be left untouched to avoid this issue.