Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): don't log error about missing use of filesystem api #10906

Merged
merged 9 commits into from Jun 5, 2019

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27099

Optional Description:
when trying to access Ti.Blob.file without a backing file/path we'd erroneously spit an error about
not using filesystem API

when trying to access Ti.Blob.file without a backing file/path we'd erroneously spit an error about
not using filesystem API

Fixes TIMOB-27099
@build
Copy link
Contributor

build commented May 23, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3613 tests are passing.
(There are 464 tests skipped)

Generated by 🚫 dangerJS against ce9d65a

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssekhri
Copy link

ssekhri commented May 29, 2019

FR Passed. No errors logged during debug.

@ssekhri
Copy link

ssekhri commented May 29, 2019

Jenkins build failing hence not merged yet.

@sgtcoolguy sgtcoolguy modified the milestones: 8.1.0, 8.2.0 Jun 3, 2019
@keerthi1032 keerthi1032 merged commit b8e5cd2 into tidev:master Jun 5, 2019
sgtcoolguy added a commit that referenced this pull request Jun 11, 2019
when trying to access Ti.Blob.file without a backing file/path we'd erroneously spit an error about
not using filesystem API

Fixes TIMOB-27099
@sgtcoolguy sgtcoolguy deleted the TIMOB-27099 branch June 11, 2019 18:27
hansemannn pushed a commit to hansemannn/titanium_mobile that referenced this pull request Jul 8, 2019
…10906)

when trying to access Ti.Blob.file without a backing file/path we'd erroneously spit an error about
not using filesystem API

Fixes TIMOB-27099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants