Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): don't log error about missing use of filesystem api #10907

Merged
merged 2 commits into from May 30, 2019
Merged

fix(ios): don't log error about missing use of filesystem api #10907

merged 2 commits into from May 30, 2019

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27099

Optional Description:
Backport/cherry-pick of #10906

when trying to access Ti.Blob.file without a backing file/path we'd erroneously spit an error about
not using filesystem API

@sgtcoolguy
fix(ios): don't log error about missing use of filesystem api
542569e 
when trying to access Ti.Blob.file without a backing file/path we'd erroneously spit an error about
not using filesystem API

Fixes TIMOB-27099
@sgtcoolguy sgtcoolguy added this to the 8.0.2 milestone May 23, 2019
@build build requested a review from a team May 23, 2019 15:44
@build
Copy link
Contributor

build commented May 23, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 1 tests have failed There are 1 tests failing and 450 skipped out of 3024 total tests.

Tests:

Classname Name Time Error
android.emulator.Titanium.UI.WebView .zoomLevel 10.154 timeout of 10000ms exceeded

Generated by 🚫 dangerJS against a1465e7

vijaysingh-axway
vijaysingh-axway approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssekhri
Copy link

ssekhri commented May 29, 2019

FR Passed. No errors logged during debug.

@sgtcoolguy sgtcoolguy merged commit 88cce36 into tidev:8_0_X May 30, 2019
@sgtcoolguy sgtcoolguy deleted the TIMOB-27099-8_0_X branch May 30, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@ssekhri ssekhri

Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgtcoolguy @build @ssekhri @vijaysingh-axway