Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): allow music-player in MediaPlayer import (8.0.1+ regression) #10913

Merged
merged 2 commits into from May 29, 2019

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented May 27, 2019

@build build added this to the 8.1.0 milestone May 27, 2019
@build build requested a review from a team May 27, 2019 17:06
@build
Copy link
Contributor

build commented May 27, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Warnings
⚠️

🔍 Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍

Generated by 🚫 dangerJS against fd65485

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: MediaPlayer import now works again.

Tested with the following test case:

var win = Ti.UI.createWindow({
backgroundColor: 'white'
});
win.open();
win.addEventListener('open', function() {
Titanium.Media.openMusicLibrary();
});

Test Environment

iPhone 6S plus (12.2 Sim)
APPC CLI: 7.0.12-70X.4
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.11.3
Xcode 10.2.1

@sgtcoolguy sgtcoolguy merged commit 13ee154 into tidev:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants