fix(android): TabGroup bar background color is wrongly transparent on Android 4.4 as of 8.0.0 #10928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transparent on Android 4.4 - Regression as of Titanium 8.0.0 - Modified to fetch colors from ActionBar style XML for backward compaitibility with apps built before Titanium 8.0.0
|
ssjsamir
approved these changes
Jun 11, 2019
There was a problem hiding this comment.
FR Passed TabGroup bar background color is no longer wrongly transparent on Android 4.4.
Tested using the test case mentioned above along with the test steps.
Test Environment
Nexus 5X (4.4.2)
7.0.12-70X.4
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 10.13.0
hansemannn
pushed a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Jul 8, 2019
…transparent on Android 4.4 (tidev#10928) - Regression as of Titanium 8.0.0 - Modified to fetch colors from ActionBar style XML for backward compaitibility with apps built before Titanium 8.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
Summary:
TabGroupbar background color is wrongly transparent on Android 4.4 as of Titanium 8.0.0.TabGroupto fetch bar background color and text color fromActionBarstyle/theme for backward compatibility.Test: