Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios) : add support for Xcode 11 / iOS 13 dev environment #10932

Merged
merged 9 commits into from Jul 18, 2019
Merged

feat(ios) : add support for Xcode 11 / iOS 13 dev environment #10932

merged 9 commits into from Jul 18, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.2.0 milestone Jun 4, 2019
@build
Copy link
Contributor

build commented Jun 4, 2019 •
edited

Warnings
⚠️

Commit 6d31046257196aa751ed98a0f728606d6dae60ab has a message "chore(ios) : Added support for Xcode 11 / iOS 13 dev environment" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit e5bd9fc9dd2a72dae983bde75502d892f80ab92f has a message "feat(iOS): Removed IS_XCODE_9 constants from code" giving 2 errors:

  • scope must be lower-case
  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3728 tests are passing.
(There are 470 tests skipped)
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 93061ef

@janvennemann janvennemann changed the title chore(ios) : Added support for Xcode 11 / iOS 13 dev environment feat(ios) : add support for Xcode 11 / iOS 13 dev environment Jun 24, 2019
@janvennemann
Copy link
Contributor

@vijaysingh-axway are there any changes suggested by Xcode to our project templates, like adjusting build settings? If so we should also apply those.

@build build requested a review from a team June 24, 2019 17:33
@vijaysingh-axway vijaysingh-axway mentioned this pull request Jun 25, 2019
Merged
@vijaysingh-axway
Copy link
Contributor Author

@vijaysingh-axway are there any changes suggested by Xcode to our project templates, like adjusting build settings? If so we should also apply those.

@janvennemann I don't see anything like that.

@vijaysingh-axway
Copy link
Contributor Author

@sgtcoolguy/@janvennemann Can you please review this? If everything looks fine can it be merged please. Thanks!

@hansemannn
Copy link
Collaborator

This one is useful for our upcoming pull requests as well, especially the new precompile flag.

janvennemann
janvennemann requested changes Jul 18, 2019
View reviewed changes
iphone/iphone/Titanium_Prefix.pch Outdated Show resolved Hide resolved
iphone/iphone/Titanium_Prefix.pch Show resolved Hide resolved
@janvennemann janvennemann merged commit 8cac1f8 into tidev:master Jul 18, 2019
ewanharris
ewanharris reviewed Jul 29, 2019
View reviewed changes
iphone/package.json
@@ -19,8 +19,8 @@
"minIosVersion": "9.0",
"minWatchosVersion": "2.0",
"vendorDependencies": {
"xcode": ">=8.0 <=10.x",
"ios sdk": ">=9.0 <=12.x"
"xcode": ">=9.0 <=11.x",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does raising this and the below ios sdk values cause breakage? As I understand it this is used to handle our minimum versions right?

@vijaysingh-axway vijaysingh-axway mentioned this pull request Jul 29, 2019
Merged
ewanharris added a commit to ewanharris/titanium_mobile that referenced this pull request Aug 1, 2019
@ewanharris
fix(ios): add back ios 11 constants to code
a08aa2e 
Rename from IS_XCODE_9 to IS_IOS_SDK_11 per the discussion in tidev#10932
ewanharris added a commit to ewanharris/titanium_mobile that referenced this pull request Aug 5, 2019
@ewanharris
fix(ios): add back ios 11 constants to code
712fb39 
Rename from IS_XCODE_9 to IS_IOS_SDK_11 per the discussion in tidev#10932
ssekhri pushed a commit that referenced this pull request Aug 19, 2019
@ewanharris
fix(ios): fix compatability with iOS 9 (#11091)
a73ebca 
* fix(ios): fix compatability with iOS 9

Fixes TIMOB-27292

* build(ios): correct property used for minimum ios version

* refactor: pull minIosVersion off package.json object

* fix(ios): add back ios 11 constants to code

Rename from IS_XCODE_9 to IS_IOS_SDK_11 per the discussion in #10932

* fix(ios): correct minimum xcode version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris left review comments

@janvennemann janvennemann janvennemann approved these changes

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
ios no tests
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @janvennemann @hansemannn @ewanharris