Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_1_X): Window.open() wrongly does fade-in animation by default as of 8.0.1 #10933

Merged
merged 5 commits into from Jun 5, 2019
Merged

fix(android)(8_1_X): Window.open() wrongly does fade-in animation by default as of 8.0.1 #10933

merged 5 commits into from Jun 5, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 8.1.0 milestone Jun 4, 2019
@build build requested review from a team June 4, 2019 22:37
@build
Copy link
Contributor

build commented Jun 4, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3546 tests are passing.
(There are 461 tests skipped)

Generated by 🚫 dangerJS against 415c51a

@keerthi1032
Copy link
Contributor

FR passed. Tested with the test case provided in the master PR. Windows Transition works as expected.
Test Environment:
Operating System
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local SDK 8.1.0.v20190604145210
Device =Samsung s5 android 6, Oneplus 5T android 9

@lokeshchdhry lokeshchdhry merged commit 41af65a into tidev:8_1_X Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug docs in-qe-testing 🕵
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @keerthi1032 @lokeshchdhry