Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): handle duplicate ShortcutItems #10943

Merged
merged 6 commits into from Jun 26, 2019

Conversation

garymathews
Copy link
Contributor

  • Fix handling of duplicate shortcut IDs
TEST CASE
for (let i = 0; i < 32; i++) {
    let shortcut = Ti.UI.createShortcutItem({
        id: 'test_shortcut',
        title: 'Test Shortcut',
        description: 'Test shortcut description',
        icon: Ti.Android.R.drawable.ic_menu_send
    });
    shortcut.show();
}
  • Should not see
java.lang.IllegalArgumentException: Max number of dynamic shortcuts exceeded

JIRA Ticket

@garymathews garymathews added this to the 8.1.0 milestone Jun 5, 2019
@garymathews garymathews modified the milestones: 8.1.0, 8.2.0 Jun 5, 2019
@build build requested a review from a team June 5, 2019 21:54
@build
Copy link
Contributor

build commented Jun 5, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3615 tests are passing.
(There are 464 tests skipped)

Generated by 🚫 dangerJS against 21d0bd5

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

We do not see java.lang.IllegalArgumentException: Max number of dynamic shortcuts exceeded error anymore.

Studio Ver: 5.1.3.201906102126
SDK Ver: 8.2.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 10.2.1
Appc NPM: 4.2.13
Appc CLI: 7.0.12
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.10
Node Ver: 8.15.1
NPM Ver: 6.4.1
Java Ver: 10.0.2
Devices: ⇨ google Pixel (Android 9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants