fix(android): fix for changing tabs properties after creation (8_0_X) #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for changing TabGroup's tabs' properties after they are created. Now every implementation of AbstractTabGroup must take care of the exposed properties. Improvement of properties handling - they are now separated for title, tilteColor, background drawable and icon. Imports clean up. (cherry picked from commit e1ec5e2)
Set the background drawalbe and title color state list only when a new item is added. Then the whole menu is recreated and some of the properties may get wiped. In other updates use the index property for updates. Remove one unnecessary line. (cherry picked from commit 62762f4)
|
ssjsamir
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
FR Passed: Able to change tab properties after creation, tested using the following test case:
var win1 = Ti.UI.createWindow({
backgroundColor: 'blue',
title: 'Blue'
});
var button = Ti.UI.createButton({ title: 'Change tab' });
button.addEventListener('click', function () {
tab1.icon = '/images/ChatBadge.png';
tab1.title = 'changed';
});
win1.add(button);
var win2 = Ti.UI.createWindow({
backgroundColor: 'red',
title: 'Red'
});
win2.add(Ti.UI.createLabel({ text: 'I am a red window.' }));
var tab1 = Ti.UI.createTab({
window: win1,
title: 'Blue'
}),
tab2 = Ti.UI.createTab({
window: win2,
title: 'Red'
}),
tabGroup = Ti.UI.createTabGroup({
tabs: [ tab1, tab2 ]
});
tabGroup.open();
Test Environment
Pixel XL (7.1)
7.0.12-70X.4
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.11.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27075
Description:
Cherry pick of: #10950