Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): prevent multiple exception logs #10962

Merged
merged 3 commits into from Jun 19, 2019

Conversation

garymathews
Copy link
Contributor

  • Prevent multiple unnecessary TiExceptionHandler logs when handlers are present

JIRA Ticket

@build
Copy link
Contributor

build commented Jun 14, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 1 tests have failed There are 1 tests failing and 464 skipped out of 3615 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Window#addSharedElement()5.047
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:4290:23)

Generated by 🚫 dangerJS against 5d1b6cf

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Their is no longer multiple unnecessary TiExceptionHandler logs when handlers are present. (Only 1 set now). Tested with the following test case:

  • Include {{com.appcelerator.aca}} module
  • Throw an exception
    throw new Error('exception');
  • Should NOT see multiple {{TiExceptionHandler}} logs

Test Environment

Pixel XL (7.1)
7.0.12-70X.4
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.11.3

@sgtcoolguy sgtcoolguy merged commit b735f54 into tidev:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants