Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): only delete build dir when force clean build #10965

Merged
merged 2 commits into from Jun 19, 2019

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27155

Optional Description:

Fixes a regression introduced when moving from wrench to fs-extra which would delete the entire build dir on every build.

@build
Copy link
Contributor

build commented Jun 17, 2019

Warnings
⚠️

iphone/cli/commands/_build.js#L5884 - iphone/cli/commands/_build.js line 5884 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)

⚠️

iphone/cli/commands/_build.js#L6411 - iphone/cli/commands/build.js line 6411 – 'code' is defined but never used. Allowed unused args must match /^.+/. (no-unused-vars)

⚠️

iphone/cli/commands/_build.js#L6411 - iphone/cli/commands/build.js line 6411 – 'out' is defined but never used. Allowed unused args must match /^.+/. (no-unused-vars)

Messages
📖

✅ All tests are passing
Nice one! All 1750 tests are passing.
(There are 239 tests skipped)

Generated by 🚫 dangerJS against 0f55419

@ssekhri
Copy link

ssekhri commented Jun 18, 2019

FR Passed. Incremental builds working fine for iOS
Verified on:
Mac OS 10.14.3
Ti SDK: 8.2.0.v20190617024817
Appc CLI: 7.0.11
Node: 10.13.0
JDK: 1.8.0_144
XCode: 10.2.1

@sgtcoolguy sgtcoolguy merged commit 7842db7 into tidev:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants