fix(android): set ListItem properties into proxy properties

[garymathews]

• Set ListItem properties on components
• Move composeContentDescription() in appropriate place

TEST CASE

• Enable Text-to-Speech
• Select each item to confirm accessibilityHint has been set

const win = Ti.UI.createWindow({
    backgroundColor: 'white'
});
const listView = Ti.UI.createListView({
    templates: {
        template: {
            childTemplates: [{
                    type: 'Ti.UI.Label',
                    bindId: 'info',
                    properties: {
                        color: 'black',
                        font: {
                            fontFamily: 'Arial',
                            fontSize: '20dp',
                            fontWeight: 'bold'
                        },
                        left: '60dp',
                        top: 0
                    }
                },
                {
                    type: 'Ti.UI.Label',
                    bindId: 'es_info',
                    properties: {
                        color: 'gray',
                        font: {
                            fontFamily: 'Arial',
                            fontSize: '14dp'
                        },
                        left: '60dp',
                        top: '25dp'
                    }
                }
            ]
        }
    },
    defaultItemTemplate: 'template'
});

listView.setSections([
    Ti.UI.createListSection({
        headerTitle: 'Fruits / Frutas',
        items: [{
                info: {
                    text: 'Apple',
                    accessibilityLabel: 'Apple Label'
                },
                es_info: {
                    text: 'Manzana',
                    accessibilityHint: 'Manzana Hint'
                }
            },
            {
                info: {
                    text: 'Banana',
                    accessibilityLabel: 'Banana Label',
                    accessibilityValue: 'Banana Value'
                },
                es_info: {
                    text: 'Banana',
                    accessibilityHint: 'Banana Hint',
                    accessibilityValue: 'Banana Value'
                }
            }
        ]
    })
]);

win.add(listView);
win.open();

JIRA Ticket

[build]

	Messages
📖	👍 Hey!, You deleted more code than you added. That's awesome!
📖	💾 Here's the generated SDK zipfile.
📖	✅ All tests are passing Nice one! All 3701 tests are passing. (There are 470 tests skipped)
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 962fb66

[drauggres]

Hardcoded content description should be removed:
https://github.com/appcelerator/titanium_mobile/blob/1a06cece2c5808b5e50787e051d7eff71895049f/android/modules/ui/res/layout/titanium_ui_list_item.xml#L28

[drauggres]

I almost sure that you must add TiC.PROPERTY_ACCESSIBILITY_* propertiest to MUST_SET_PROPERTIES list
https://github.com/appcelerator/titanium_mobile/blob/1a06cece2c5808b5e50787e051d7eff71895049f/android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/TiListView.java#L89-L98

[sgtcoolguy]

LGTM, See backport for additional comments about minor code clean up.

comments marked as resolved

[lokeshchdhry]

FR Passed.

Accessibility label in the ListItem components. Enabling text to speech speaks out the accessibility label & value as expected.

Studio Ver: 5.1.3.201906102126
SDK Ver: 8.2.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 10.2.1
Appc NPM: 4.2.14-3
Appc CLI: 7.1.0-master.24
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.1
Alloy Ver: 1.14.0
Node Ver: 8.15.1
NPM Ver: 6.4.1
Java Ver: 10.0.2
Devices: ⇨ google Pixel (Android 9)