fix(android)(8_1_X): set ListItem properties into proxy properties #10979
Conversation
|
garymathews
force-pushed
the
TIMOB-24415_81X
branch
from
88f59d4
to
800ae22
Compare
| @@ -285,7 +285,7 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP | |||
| } | |||
| ViewCompat.setImportantForAccessibility(listView, importance); | |||
| } else { | |||
| listView.setContentDescription(composeContentDescription()); | |||
| listView.setContentDescription(getProxy().composeContentDescription()); | |||
There was a problem hiding this comment.
can getProxy() return null?
| @@ -675,12 +678,18 @@ public void populateViews(KrollDict data, TiBaseListViewItem cellContent, TiList | |||
| KrollDict properties = new KrollDict((HashMap) data.get(binding)); | |||
| KrollDict diffProperties = viewItem.generateDiffProperties(properties); | |||
| if (!diffProperties.isEmpty()) { | |||
| if (viewProxy != null && viewProxy.getProperties() != null) { | |||
There was a problem hiding this comment.
extract temp var to assign viewProxy.getProperties() value to?
| view.processProperties(diffProperties); | ||
| } | ||
|
|
||
| } else if (dataItem != null && view != null) { | ||
| KrollDict diffProperties = viewItem.generateDiffProperties(dataItem.getDefaultProperties()); | ||
| if (!diffProperties.isEmpty()) { | ||
| if (viewProxy != null && viewProxy.getProperties() != null) { |
| return null; | ||
| } | ||
|
|
||
| final String punctuationPattern = "^.*\\p{Punct}\\s*$"; |
There was a problem hiding this comment.
Extract to a constant so it's compiled once?
| String hint = TiConvert.toString(properties.get(TiC.PROPERTY_ACCESSIBILITY_HINT)); | ||
| String value = TiConvert.toString(properties.get(TiC.PROPERTY_ACCESSIBILITY_VALUE)); | ||
|
|
||
| if (!TextUtils.isEmpty(label)) { |
There was a problem hiding this comment.
These three small blocks are identical, extract to a method? Only wrinkle is the extra space prefix/suffix added if previous value was not empty...
buffer.append(composeContentSegment(TiC.PROPERTY_ACCESSIBILITY_LABEL));
buffer.append(composeContentSegment(TiC.PROPERTY_ACCESSIBILITY_HINT));
buffer.append(composeContentSegment(TiC.PROPERTY_ACCESSIBILITY_VALUE));
|
FR Passed. Accessibility label in the ListItem components. Enabling text to speech speaks out the accessibility label & value as expected. Studio Ver: 5.1.3.201906102126 |
JIRA Ticket