New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Allow touch feedback for image and gradient backgrounds #10986
Conversation
Touch feedback property is now available for views with an image or a gradient backgrounds.
|
android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java
Outdated
Show resolved
Hide resolved
android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java
Outdated
Show resolved
Hide resolved
nativeView.setBackgroundColor(bgColor); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing this block of code will cause a regression where you can no longer change a view's backgroundColor
dynamically anymore because setBackgroundColor()
won't get called.
Closing in favor of PR #11795 . |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26315
Description:
Touch feedback property is now available for views with an image or a gradient backgrounds.
No unit tests since this is a visual improvement.
Test case: