Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iOS): Supported new UITableViewStyleInsetGrouped style in table view and list view #10994

Merged
merged 12 commits into from Aug 29, 2019
Merged

chore(iOS): Supported new UITableViewStyleInsetGrouped style in table view and list view #10994

merged 12 commits into from Aug 29, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Jun 25, 2019 •
edited

@build build added this to the 8.2.0 milestone Jun 25, 2019
@build build requested review from a team June 25, 2019 18:41
@build
Copy link
Contributor

build commented Jun 25, 2019 •
edited

Warnings
⚠️

Commit 6d31046257196aa751ed98a0f728606d6dae60ab has a message "chore(ios) : Added support for Xcode 11 / iOS 13 dev environment" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit e5bd9fc9dd2a72dae983bde75502d892f80ab92f has a message "feat(iOS): Removed IS_XCODE_9 constants from code" giving 2 errors:

  • scope must be lower-case
  • subject must not be sentence-case, start-case, pascal-case, upper-case
⚠️

Commit 25abe153b2ce5f7684b61ac0916f4fe6ff492014 has a message "chore(iOS): Supported new UITableViewStyleInsetGrouped style in tableview" giving 3 errors:

  • header must not be longer than 72 characters, current length is 73
  • scope must be lower-case
  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4368 tests are passing.
(There are 472 tests skipped)
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 2abfeb5

@vijaysingh-axway
chore(ios): fixed probable crash issue
0f8b7e5 
fixed probable crash issue
@vijaysingh-axway
Merge remote-tracking branch 'upstream/master' into TIMOB-27171
3ae7ba7 
# Conflicts:
#	iphone/Classes/TiAppiOSUserNotificationCenterProxy.m
#	iphone/Classes/UIModule.m
#	iphone/iphone/Titanium_Prefix.pch
@vijaysingh-axway
chore(ios): updated constant
66a0774
janvennemann
janvennemann approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keerthi1032
Copy link
Contributor

FR passed. New UITableViewStyleInsetGrouped style supported on ios 13
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.2.0.v20190718160307
Device - iPhone XR iOS 13
Simulator -iPhone X iOS 13,iphone 6 iOS 12

@hansemannn
Copy link
Collaborator

hansemannn commented Aug 17, 2019 •
edited

@keerthi1032 @vijaysingh-axway This won't be able to merge until a unit test or np tests is added.

@sgtcoolguy sgtcoolguy merged commit bc30ee8 into tidev:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn left review comments

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
docs in-qe-testing 🕵 ios
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vijaysingh-axway @build @keerthi1032 @hansemannn @janvennemann @sgtcoolguy