Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_1_X): handle duplicate ShortcutItems #11000

Merged
merged 3 commits into from Jun 27, 2019
Merged

fix(android)(8_1_X): handle duplicate ShortcutItems #11000

merged 3 commits into from Jun 27, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 8.1.0 milestone Jun 27, 2019
@jquick-axway jquick-axway changed the title fix(android)(8_0_X): handle duplicate ShortcutItems fix(android)(8_1_X): handle duplicate ShortcutItems Jun 27, 2019
@build build requested a review from a team June 27, 2019 00:36
@build
Copy link
Contributor

build commented Jun 27, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3615 tests are passing.
(There are 464 tests skipped)

Generated by 🚫 dangerJS against 1447da2

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Jun 27, 2019 •
edited

FR Passed.

We do not see java.lang.IllegalArgumentException: Max number of dynamic shortcuts exceeded error anymore.

Studio Ver: 5.1.3.201906102126
SDK Ver: 8.1.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 10.2.1
Appc NPM: 4.2.13
Appc CLI: 7.0.12
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.10
Node Ver: 8.15.1
NPM Ver: 6.4.1
Java Ver: 10.0.2
Devices: ⇨ google Pixel (Android 9)

@lokeshchdhry lokeshchdhry merged commit 666d807 into tidev:8_1_X Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @build @lokeshchdhry