fix(android): Fix Up button flickering when clicked in NavigationWindow #11003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27190
Description:
The Up button disappears before the Window is actually closed when this is done in a
NavigationWindow's Windows stack.
This was happening due the displayOptions flags being set after the ActionBar is drawn and immediately before closing the Window. In this PR setting the child Window's
showHomeAsUp
is done through theActionBarProxy
class instead of directly theSupportActionBar
instance.Note: This is a visual fix so there is no unit test for it.
Test case:
There is a short clip in the JIRA ticket that demonstrates what is the mentioned flicker.