Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Fix Up button flickering when clicked in NavigationWindow #11003

Merged
merged 3 commits into from Sep 9, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Jun 27, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27190

Description:
The Up button disappears before the Window is actually closed when this is done in a
NavigationWindow's Windows stack.
This was happening due the displayOptions flags being set after the ActionBar is drawn and immediately before closing the Window. In this PR setting the child Window's showHomeAsUp is done through the ActionBarProxy class instead of directly the SupportActionBar instance.

Note: This is a visual fix so there is no unit test for it.

Test case:

const win1 = Ti.UI.createWindow(),
	win2 = Ti.UI.createWindow(),
	navWin = Ti.UI.createNavigationWindow({ window: win1}),
	but = Ti.UI.createButton({ title: 'Nav'});
navWin.open();
win1.add(but);
butt.addEventListener('click', () => {
	navWin.openWindow(win2);
});

There is a short clip in the JIRA ticket that demonstrates what is the mentioned flicker.

There Up button disappears before the Window is actually closed when this is done in a
NavigationWindow's Windows stack.
@ypbnv ypbnv added this to the 8.2.0 milestone Jun 27, 2019
@ypbnv ypbnv requested a review from jquick-axway June 27, 2019 12:57
@build build requested a review from a team June 27, 2019 13:26
@build
Copy link
Contributor

build commented Jun 27, 2019

Warnings
⚠️ This PR has milestone set to 8.3.0, but the version defined in package.json is 8.2.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
⚠️

Commit 5817985453f7e60a939f9865e1ded19973d2064b has a message "fix(android): Fix Up button flickering when clicked in NavigationWindow

There Up button disappears before the Window is actually closed when this is done in a
NavigationWindow's Windows stack." giving 1 errors:

  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4335 tests are passing.
(There are 472 tests skipped)

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 0429e69

@jquick-axway jquick-axway modified the milestones: 8.2.0, 8.3.0 Jun 27, 2019
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssekhri
Copy link

ssekhri commented Jul 29, 2019

FR Passed.
No flicker when closing the Nav window using the Nav window back button or android's back button.
Verified using:
Mac OS 10.14.3
Ti SDK: 8.2.0.v20190627060333
Appc CLI: 7.1.0-24
Node: 8.16.0
JDK: 10.0.2

@sgtcoolguy sgtcoolguy merged commit 69dfda5 into tidev:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants