Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_1_X): TabGroup crashes if tab "title" property not set as of 8.0.2 #11004

Merged
merged 3 commits into from Jul 1, 2019
Merged

fix(android)(8_1_X): TabGroup crashes if tab "title" property not set as of 8.0.2 #11004

merged 3 commits into from Jul 1, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 8.1.0 milestone Jun 27, 2019
@build build requested a review from a team June 27, 2019 19:47
@build
Copy link
Contributor

build commented Jun 27, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3625 tests are passing.
(There are 464 tests skipped)

Generated by 🚫 dangerJS against 7791357

@keerthi1032
Copy link
Contributor

FR passed. No tab group crash if title property set/not .tested with the test case provided in the PR.
Test Environment:
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = 8.1.0.v20190627121218
Device = oneplus 5t android 9,nexus 5 ANDORID 5,
Emulator = pixel 3xl android 9

@sgtcoolguy sgtcoolguy merged commit 7305765 into tidev:8_1_X Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @keerthi1032 @sgtcoolguy