fix(ios): fallback to non-widget require in catch #11008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ewanharris
force-pushed
the
TIMOB-27195
branch
2 times, most recently
from
0ddc7e0
to
2f391f9
Compare
ewanharris
force-pushed
the
TIMOB-27195
branch
from
0399b32
to
d4f4222
Compare
ssjsamir
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
FR Passed: Able to now use a commonjs module in an itemtemplate without the build throwing an error. Tested with the following application: https://github.com/ewanharris/ti.imageview-listview-example
Test Environment
MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 6s (12.2)
"NPM":"4.2.14","CLI":"7.1.1-master.2"
This ensures that when the alloy require fails we try the normal require Fixes TIMOB-27195
ewanharris
force-pushed
the
TIMOB-27195
branch
from
cbf9987
to
22b2f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that when the alloy require fails we try the normal require
Fixes TIMOB-27195
JIRA: https://jira.appcelerator.org/browse/TIMOB-27195