Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): proper ’url’ for ‘beforeload’ event set #11020

Merged
merged 8 commits into from Aug 29, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.2.0 milestone Jul 2, 2019
@build build requested a review from a team July 2, 2019 18:15
@build
Copy link
Contributor

build commented Jul 2, 2019

Warnings
⚠️

Commit 949b76a9d06fd5ed22dab8ae250e56a7598b567e has a message "fix(iOS): Proper ’url’ for ‘beforeload’ event set" giving 2 errors:

  • scope must be lower-case
  • subject must not be sentence-case, start-case, pascal-case, upper-case
⚠️

Commit a5ba2cb7cf115c0a4b5e2d9ed1da535a340b44c0 has a message "fix(ios) : Unit test added" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit d02d26ad869902fae1a591945b44010df46c02ca has a message "fix(ios): Fix issue in test case" giving 1 errors:

  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4368 tests are passing.
(There are 472 tests skipped)

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 00d2ee9

@janvennemann
Copy link
Contributor

@vijaysingh-axway please add a simple unit test for this change

@keerthi1032
Copy link
Contributor

FR passed. @"url" : navigationAction.request.URL is set on before load now and works as expected.
Test Environment:
Operating System
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 8.9.0
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.2.0.v20190718144541
Device = iPhone X iOS 11
Simulator =iPhone XR iOS 12

@vijaysingh-axway vijaysingh-axway changed the title fix(iOS): Proper ’url’ for ‘beforeload’ event set fix(iOS): proper ’url’ for ‘beforeload’ event set Aug 29, 2019
@sgtcoolguy sgtcoolguy merged commit fb37213 into tidev:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants