Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to node-appc@0.3.3 #11025

Merged
merged 1 commit into from Jul 4, 2019

Conversation

ewanharris
Copy link
Collaborator

TIMOB-27203 - iOS: no apiversion validation performed on application build

TIMOB-27204 - CLI: apiversion validation always fails for native modules installed via npm

Fixes TIMOB-27203 and TIMOB-27204
@build
Copy link
Contributor

build commented Jul 3, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3536 tests are passing.
(There are 464 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Dependencies with modified semantic versioning:

Generated by 🚫 dangerJS against aa88b71

@ssjsamir ssjsamir self-requested a review July 4, 2019 16:13
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR and CR Passed: iOS: apiversion validation is now performed on application build. Tested using the following test steps:

  1. Add the following module to your tiapp modules section com.appcelerator.aca
  2. Open the manifest file (probably at /Users/eharris/Library/Application Support/Titanium/modules/iphone/com.appcelerator.aca/1.1.0/manifest)
  3. Change the apiversion to anything other than 2
  4. Build with ti build -p ios --build-only

CLI: apiversion validation always no longer fails for native modules installed via npm Tested using the following test steps:

  1. In the root of your titanium project alongside tiapp.xml, run npm init -y and then npm i @titanium/imagefactory
  2. Add ti.imagefactory to your modules section in the tiapp
  3. Build for Android or iOS (iOS will require TIMOB-27203 to be fixed first)

Test Environment

MacOS Mojave version 10.14.4
Xcode 10.2.1
Node.js ^8.12.0
iPhone 6s Sim(12.1).
Android pixel XL 7.1
Node 10.13.0

@ssjsamir ssjsamir merged commit b9e61d4 into tidev:master Jul 4, 2019
@ewanharris ewanharris deleted the update_node-appc branch August 31, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants