Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): remove additional gc protection once proxy is remembered (8_1_X) #11029

Closed
wants to merge 2 commits into from

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann added this to the 8.1.1 milestone Jul 5, 2019
@build build requested a review from a team July 5, 2019 11:51
@build
Copy link
Contributor

build commented Jul 5, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 3 tests have failed There are 3 tests failing and 470 skipped out of 3705 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation#forwardGeocoder() (as approximately)1.973
Error: expected 37.3909049 to be approximately 37.387 ±0.002
at Assertion.fail (/node_modules/should/cjs/should.js:275:17)
      at Assertion.value [as approximately] (/node_modules/should/cjs/should.js:356:19)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:260:34)
android.emulator.Titanium.Network.HTTPClientcallbackTestForGETMethod9.909
Error: 404 : Not Found
at HTTPClient.xhr.onerror (/ti.network.httpclient.test.js:410:16)
ios.Titanium.Database#executeAllAsync() does not allow DB to be GC'd60.006
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/29E1514E-93D8-4A4B-A306-F232955340BA/data/Containers/Bundle/Application/93E23638-2F5E-4A0B-9DD5-69C0E9506896/mocha.app/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against 14ab1fd

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the original PR, code looks all right, trusting your knowledge is correct here 👍

(QE please see the original PR for FR test steps)

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Oct 10, 2019

Closing as fix is not needed in 8_1_X & backport for 8_2_X is created here #11274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants