Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-27164 iOS: Implement async Ti.Database.DB methods (8_1_X) #11034

Merged
merged 13 commits into from Jul 12, 2019
Merged

TIMOB-27164 iOS: Implement async Ti.Database.DB methods (8_1_X) #11034

merged 13 commits into from Jul 12, 2019

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-27164

Description:
Backport of CR'd #11022

@sgtcoolguy sgtcoolguy added this to the 8.1.0 milestone Jul 8, 2019
@build build requested review from a team July 8, 2019 18:57
@build build added the docs label Jul 8, 2019
@build
Copy link
Contributor

build commented Jul 8, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 4 tests have failed There are 4 tests failing and 455 skipped out of 3288 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation#reverseGeocoder()0.181
Error: expected false to equal true
at Assertion.fail (/node_modules/should/cjs/should.js:275:17)
      at Assertion.value (/node_modules/should/cjs/should.js:356:19)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:277:33)
android.emulator.Titanium.Geolocation#forwardGeocoder()0.151
Error: expected false to equal true
at Assertion.fail (/node_modules/should/cjs/should.js:275:17)
      at Assertion.value (/node_modules/should/cjs/should.js:356:19)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:257:33)
ios.Titanium.Geolocation#reverseGeocoder()0.118
Error: expected false to equal true
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/199A2DE6-3D76-4D30-9922-548438F207C9/data/Containers/Bundle/Application/DCA3B8A1-0B3F-4AF4-815F-20F58CE9B34B/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/199A2DE6-3D76-4D30-9922-548438F207C9/data/Containers/Bundle/Application/DCA3B8A1-0B3F-4AF4-815F-20F58CE9B34B/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/199A2DE6-3D76-4D30-9922-548438F207C9/data/Containers/Bundle/Application/DCA3B8A1-0B3F-4AF4-815F-20F58CE9B34B/mocha.app/ti.geolocation.test.js:277:36
ios.Titanium.Geolocation#forwardGeocoder()0.154
Error: expected false to equal true
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/199A2DE6-3D76-4D30-9922-548438F207C9/data/Containers/Bundle/Application/DCA3B8A1-0B3F-4AF4-815F-20F58CE9B34B/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/199A2DE6-3D76-4D30-9922-548438F207C9/data/Containers/Bundle/Application/DCA3B8A1-0B3F-4AF4-815F-20F58CE9B34B/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/199A2DE6-3D76-4D30-9922-548438F207C9/data/Containers/Bundle/Application/DCA3B8A1-0B3F-4AF4-815F-20F58CE9B34B/mocha.app/ti.geolocation.test.js:257:36

Generated by 🚫 dangerJS against 061de98

@sgtcoolguy
test(db): run async Ti.Database tests on ios
fdd21f5 
- no longer filter to just android, but don't run on windows
- modify tests to expect callbacks that received error as first argument
- add tests for invalid sql statements, re-work test structure
@sgtcoolguy
fix(android): handle error cases for async Ti.Database APIs
f6bfac0
@sgtcoolguy
feat(ios): add async APIs for Ti.Database
ab2de37
@sgtcoolguy
build(docs): support multiple sub-types for Callbacks in apidocs
f539702
@sgtcoolguy
docs(db): add ipad/iphone to supported platforms for new async methods
1e5223d 
fix handling of Callback type with multiple sub types
@sgtcoolguy
fix(ios): handle database close called during async queries
fc7262a 
- add tests for closing database while async queries run
@sgtcoolguy
feat(android): custom properties on Java exceptions -> JS Errors
433007c
@sgtcoolguy
test(db): error pointing at failed index on executeAll, partial results
edaa7f1
@sgtcoolguy
fix(android): pass failed index, partial results on executeAll fail
4f96be2
@sgtcoolguy
feat(ios): common method of creating JS errors from native
4d8693f
@sgtcoolguy
fix(ios): pass failed index, partial results on executeAll fail
c48e673
@sgtcoolguy
docs(db): report details on error cases for executeAll/Async
061de98
@ssjsamir ssjsamir self-requested a review July 12, 2019 11:11
ssjsamir
ssjsamir approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, able to use the new DB implemented methods without any issues on iOS:

Ti.Database.DB.executeAsync(callback, query, parameters...);
Ti.Database.DB.executeAll(queries);
Ti.Database.DB.executeAllAsync(callback, queries);

Test Environment
MacOS Mojave version 10.14.4
Xcode 10.2.1
Node.js ^8.12.0
iPhone 6s Sim (12.1).
"NPM":"4.2.13","CLI":"7.1.0-master.24"

@sgtcoolguy sgtcoolguy merged commit 6484a18 into tidev:8_1_X Jul 12, 2019
@sgtcoolguy sgtcoolguy deleted the TIMOB-27164-8_1_X branch July 12, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
android bug docs feature in-qe-testing 🕵 ios parity 👯‍♀️
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgtcoolguy @build @ssjsamir