feat(ios): expose api to use sf images

[vijaysingh-axway]

https://jira.appcelerator.org/browse/TIMOB-27133

[build]

	Warnings
⚠️	Commit 6d31046257196aa751ed98a0f728606d6dae60ab has a message "chore(ios) : Added support for Xcode 11 / iOS 13 dev environment" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit e5bd9fc9dd2a72dae983bde75502d892f80ab92f has a message "feat(iOS): Removed IS_XCODE_9 constants from code" giving 2 errors: scope must be lower-case subject must not be sentence-case, start-case, pascal-case, upper-case
⚠️	Commit be319ec10b6023c2a5dba2ed41d1c607918fa8a7 has a message "Update doc Co-Authored-By: Jan Vennemann jan.vennemann@gmx.net" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 8fb69f2bfcab69697d4bc313a1d0d6e8fa936b01 has a message "Update doc Co-Authored-By: Jan Vennemann jan.vennemann@gmx.net" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit bc2360ffa06d9a01d18d8bf1db6226b4ae919a96 has a message "Update doc Co-Authored-By: Jan Vennemann jan.vennemann@gmx.net" giving 2 errors: subject may not be empty type may not be empty

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✅ All tests are passing Nice one! All 4371 tests are passing. (There are 472 tests skipped)
📖	🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against 46fca0c

[janvennemann]

LGTM!

[janvennemann]

@vijaysingh-axway please add a unit test for the new api, thanks!

[ssjsamir]

FR Passed: Able to make use of sf images, using the following test case:

var win = Ti.UI.createWindow({
backgroundColor: '#fff'
});
var triangle = Ti.UI.iOS.systemImage('drop.triangle.fill');
var forward = Ti.UI.iOS.systemImage('forward');
var backward = Ti.UI.iOS.systemImage('backward');
var folder = Ti.UI.iOS.systemImage('folder.fill');
 
 
var imageView = Ti.UI.createImageView({
width: '150',
height: '150',
image: triangle,
tintColor: 'red'
});
 
 
var button = Ti.UI.createButton({
top: 60,
width: 100,
height: 50,
//backgroundImage: folder
image: folder
})
 
var stepper = Ti.UI.iOS.createStepper({
top: 150,
incrementImage: forward,
decrementImage: backward
});
 
 
win.add(button);
win.add(stepper);
win.add(imageView);
win.open();

Test Environment

MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 8 (13.0 Sim)
"NPM":"4.2.14","CLI":"7.1.1-master.2"

[hansemannn]

Can this be merged please?

[hansemannn]

@vijaysingh-axway @janvennemann @ssjsamir There was an issue with device builds, since the TiBlob class was not imported properly. This is fixed via vijaysingh-axway#4 which has Vijays fork as the head, so once merged it should appear here.

EDIT: Another issue was that it doesn't work for UITabItem instances like the following case. It has been fixed now as well.

var window1 = Ti.UI.createWindow();

var window2 = Ti.UI.createWindow();

var tabGroup = Ti.UI.createTabGroup({
    tabs: [
        Ti.UI.createTab({ window: window1, title: 'Home', icon: Ti.UI.iOS.systemImage('house'), activeIcon: Ti.UI.iOS.systemImage('house.fill') }),
        Ti.UI.createTab({ window: window2, title: 'Settings', icon: Ti.UI.iOS.systemImage('gear'), activeIcon: Ti.UI.iOS.systemImage('gear.fill') })
    ]
})

tabGroup.open();

[vijaysingh-axway]

Thanks @hansemannn . Merged.

[hansemannn]

We also see issues with this when using it in conditional code, even with Alloy.Globals constants. Can you reproduce it in Alloy?