Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios,android): implement exception signal handler #11071

Merged
merged 2 commits into from Jul 25, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jul 22, 2019

  • Update APSAnalytics
    • iOS: Implement flush() method to force flush event queue
    • Android: Do not retry sending events if there is no connectivity
  • Implement signal handler on iOS

TIMOB-27269
TIMOB-27270

@build
Copy link
Contributor

build commented Jul 22, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3728 tests are passing.
(There are 470 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 9f67416

@garymathews garymathews changed the title fix(ios,android): Implement exception signal handler fix(ios,android): implement exception signal handler Jul 25, 2019
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Jul 25, 2019

FR Passed.

  1. Signal error code is successfully handled & sent to the dashboard via ACA.
[DEBUG] :  ACA crash.report: {
[DEBUG] :      message = "signal error code: 11";
[DEBUG] :      meta =     {
[DEBUG] :          handled = 0;
[DEBUG] :      };
[DEBUG] :      stack =     (
[DEBUG] :          "libsystem_platform.dylib 0x000000011303cb5d _sigtramp + 29\nlibobjc.A.dylib 0x000000010f654e7f _ZN12_GLOBAL__N_119AutoreleasePoolPage3popEPv + 779\nFoundation 0x000000010c1d931e -[NSAutoreleasePool release] + 144\nTitaniumKit 0x000000010f54f79c KrollCallAsFunction + 792\nTitaniumKit 0x000000010f52b7fb TiBindingEventProcess + 670\nTitaniumKit 0x000000010f54d876 -[KrollContext invoke:] + 109\nTitaniumKit 0x000000010f54d8e9 -[KrollContext enqueue:] + 93\nTitaniumKit 0x000000010f5556fd TiBindingRunLoopEnqueue + 82\nTitaniumKit 0x000000010f553d77 -[TiProxy fireEvent:withObject:propagate:reportSuccess:errorCode:message:] + 164\nTitaniumKit 0x000000010f533d9e -[TiViewProxy fireEvent:withObject:propagate:reportSuccess:errorCode:message:] + 224"
[DEBUG] :      );
[DEBUG] :  }
  1. On Android the app does not keep retying to send events in case of no network connectivity but sends after connectivity is avaliable.

Studio Ver: 5.1.3.201907112159
SDK Ver: 8.2.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 10.3
Appc NPM: 4.2.14-3
Appc CLI: 7.1.0-24
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.1
Alloy Ver: 1.14.0
Node Ver: 10.16.0
NPM Ver: 6.9.0
Java Ver: 10.0.2
Devices: ⇨ google Pixel (Android 9)
IOS Sim: Iphone XS IOS 12.4

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garymathews iOS Changes looks good. Please include latest APSAnalytics library as you have updated PR https://github.com/appcelerator/aps_sdk/pull/335.

@garymathews
Copy link
Contributor Author

@vijaysingh-axway Already did 👍

@garymathews garymathews merged commit 1a70865 into tidev:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants