Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): remove invalid architecture from framework for adhoc build #11072

Merged
merged 8 commits into from Aug 28, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.2.0 milestone Jul 23, 2019
@build
Copy link
Contributor

build commented Jul 23, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 2 tests have failed There are 2 tests failing and 468 skipped out of 4247 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
ios.Titanium.UI.iOS#createPreviewContext()0.001
Error: expected 0 to equal 300
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti.ui.ios.previewcontext.test.js:26:48
file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti-mocha.js:5764:29
ios.Titanium.UI.Window.safeAreaPadding for window inside navigation window with extendSafeArea true0.009
Error: expected 34 to equal 0
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/F0D55214-C55D-4CBA-A7DE-4F225B49BD80/data/Containers/Bundle/Application/B4394448-5D06-45C8-B961-33C1B464A4BD/mocha.app/ti.ui.window.test.js:721:38

Generated by 🚫 dangerJS against 656b53f

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keerthi1032
Copy link
Contributor

FR passed. No unsupported architecture error thrown.

Test Enviornment:
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = 8.2.0.v20190723082323 and 8.1.0.v20190726163812
Device - iPhone X iOS 11

@sgtcoolguy sgtcoolguy merged commit 6478814 into tidev:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants