Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix compatability with iOS 9 #11091

Merged
merged 10 commits into from Aug 19, 2019
Merged

fix(ios): fix compatability with iOS 9 #11091

merged 10 commits into from Aug 19, 2019

Conversation

ewanharris
Copy link
Collaborator

Fixes TIMOB-27292

JIRA: https://jira.appcelerator.org/browse/TIMOB-27292

This adds back iOS 9 into our supported version range. I haven't touched the xcode version as I'm not fully clear on what it means to add back xcode support, I'm guessing we need to revert the IS_XCODE_9 removal?

@build build added this to the 8.2.0 milestone Jul 29, 2019
@build
Copy link
Contributor

build commented Jul 29, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4344 tests are passing.
(There are 472 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 25d8beb

@ewanharris ewanharris mentioned this pull request Jul 30, 2019
Merged
@ewanharris
Copy link
Collaborator Author

@cb1kenobi, @vijaysingh-axway fixed the build scripts to reference minIosVersion. Shall I also go ahead and work on adding back the xcode 8 compat?

@vijaysingh-axway
Copy link
Contributor

@cb1kenobi, @vijaysingh-axway fixed the build scripts to reference minIosVersion. Shall I also go ahead and work on adding back the xcode 8 compat?

@ewanharris Please change variable name as mentioned in comment. Please go ahead on adding back the xcode 8. I'll create a new ticket to make minimum Xcode change and minimum iOS SDK change in SDK 9.

@ewanharris
Copy link
Collaborator Author

ewanharris commented Aug 1, 2019 •
edited

@vijaysingh-axway, updated PR to do both of those. Also, per yours and Jan's discussion here I changed the constant from IS_XCODE_9 to IS_SDK_IOS_11

@ewanharris ewanharris mentioned this pull request Aug 1, 2019
Merged
vijaysingh-axway
vijaysingh-axway suggested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewanharris One minor change required. Everything else looks good.

iphone/package.json Outdated Show resolved Hide resolved
vijaysingh-axway
vijaysingh-axway approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssekhri
Copy link

ssekhri commented Aug 16, 2019

FR Passed.
App builds and launches successfully on iOS 9 simulator
Verified on:
Mac OS 10.14.6
Ti SDK: 8.2.0.v20190807170125
Appc CLI: 7.1.1-master.2
Node: 10.5.0
JDK: 10.0.2
Xcode: 11.0 beta 5
Studio: 5.1.3.201907112159

@ssekhri ssekhri merged commit a73ebca into tidev:master Aug 19, 2019
@ewanharris ewanharris deleted the TIMOB-27292 branch August 20, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi left review comments

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ewanharris @build @vijaysingh-axway @ssekhri @cb1kenobi @sgtcoolguy