Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): accessibility properties not returning proper value #11109

Merged
merged 7 commits into from Aug 29, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.2.0 milestone Aug 3, 2019
@build build requested a review from a team August 3, 2019 00:28
@build build added the ios label Aug 3, 2019
/* eslint no-unused-expressions: "off" */
'use strict';
var should = require('./utilities/assertions'),
utilities = require('./utilities/utilities');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ tests/Resources/ti.ui.view.addontest.js line 11 – 'utilities' is assigned a value but never used. (no-unused-vars)

@build
Copy link
Contributor

build commented Aug 3, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4371 tests are passing.
(There are 472 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against d046c4f

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor notes about code style. Rest looks good!

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ssekhri
Copy link

ssekhri commented Aug 13, 2019

FR passed.
Accessibility label, value and hint returned successfully in both classic and alloy apps.

Verified on:
Mac OS 10.14.6
Ti SDK: 8.2.0.v20190802170526
Appc CLI: 7.1.0
Node: 10.5.0
JDK: 10.0.2
Xcode: 10.3
Studio: 5.1.3.201907112159

@sgtcoolguy sgtcoolguy merged commit 70922a8 into tidev:master Aug 29, 2019
drauggres pushed a commit to NetrisTV/titanium_mobile that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants