Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): use device build as base for universal module framework (8_1_X) #11120

Merged
merged 3 commits into from Aug 28, 2019

Conversation

janvennemann
Copy link
Contributor

@build
Copy link
Contributor

build commented Aug 7, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3738 tests are passing.
(There are 470 tests skipped)

Generated by 🚫 dangerJS against f5c5dfd

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@keerthi1032
Copy link
Contributor

FR passed. CFBundleSupportedPlatforms shows as iphoneos correctly.

Test Enviornment:
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit

Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0

Titanium CLI
CLI Version = 5.2.1

Titanium SDK
SDK Version = local sdk 8.1.0.v20190812124353,8.2.0.v20190807042312

@sgtcoolguy sgtcoolguy merged commit f382518 into tidev:8_1_X Aug 28, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Sep 20, 2019
* 8_1_X:
  chore(release): bump version
  chore(8_1_X): update aps-analytics (tidev#11179)
  fix(ios): console and tiapi multiple parameter log (tidev#11162)
  fix(ios): use device build as base for universal module framework (tidev#11120)
  fix(ios)(8_1_X): properly load watchsession module (tidev#11174)
  fix(ios): remove invalid architecture from framework for adhoc build (tidev#11087)
  refactor(android)(8_1_X): ProgressIndicator dialog handling (tidev#11142)
  refactor(android): consolidate incremental build fixes back into task (tidev#10997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants