Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): update titanium_prep windows binaries #11121

Merged
merged 1 commit into from Aug 7, 2019

Conversation

ewanharris
Copy link
Collaborator

@build build added this to the 8.2.0 milestone Aug 7, 2019
@build
Copy link
Contributor

build commented Aug 7, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 1 tests have failed There are 1 tests failing and 472 skipped out of 4328 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.TabbedBarIndex - direct change5.672
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:4326:18)

Generated by 🚫 dangerJS against c2003ec

@ssjsamir ssjsamir self-requested a review August 7, 2019 17:46
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to build to Android device on windows now.

Test Environment

Operating System
Name = Microsoft Windows 10 Pro
Version = 10.0.18362
Architecture = 64bit

CPUs = 4
Memory = 32.0GB
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1

Appcelerator CLI
Core Package = 7.1.0-master.24

Titanium CLI
CLI Version = 5.2.1
node-appc Version = 0.2.49

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgtcoolguy sgtcoolguy merged commit 268216a into tidev:master Aug 7, 2019
@ewanharris ewanharris deleted the TIMOB-27314 branch August 7, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants