Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): properly inject CODE_SIGN_IDENTITY flag for Xcode 11 compatibility #11133

Closed
wants to merge 2 commits into from

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Aug 12, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27330

Requires tidev/ioslib#91 + package.json update to 1.7.11 once merged.

@build
Copy link
Contributor

build commented Aug 12, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

✅ All tests are passing
Nice one! All 4342 tests are passing.
(There are 472 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.10 to ^1.7.11

Generated by 🚫 dangerJS against c16f49d

@hansemannn
Copy link
Collaborator Author

Using the old certificates fixed it for me. Although I'd still argue that we should properly assign certs directly instead of gambling that Xcode does it for us in the future.

Also, still not supporting automatic code signing these days is really bad and will cause more and more issues in the future as developers move to generating their certs automatically.

@hansemannn hansemannn closed this Aug 22, 2019
@cb1kenobi
Copy link
Contributor

@hansemannn We used to explicitly set the certificate, but then I believe we went to the generic "iPhone Developer" when we added Apple Watch support. We mix the watch app targets into the Titanium app's Xcode project and wire up the target dependencies and I believe that there were issues signing the watch apps and the iOS app when using an explicit cert.

I'm not opposed to looking at it again, we just need to remember to test watch apps. :)

+1 for the "Apple Developer" cert support.

@hansemannn
Copy link
Collaborator Author

Makes sense. Can you remove the milestone? Then we should be fine :)

@hansemannn hansemannn deleted the TIMOB-27330 branch August 22, 2019 16:12
@cb1kenobi cb1kenobi removed this from the 8.2.0 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants