refactor(android)(8_1_X): ProgressIndicator dialog handling #11142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [TIMOB-27104] ProgressIndicator logs "WindowLeaked" exception when hiding dialog and closing window at same time as of 8.0.2 - [TIMOB-27308] Determinant ProgressIndicator ignores "value" property before shown - [TIMOB-27309] Cannot re-show ProgressIndicator dialog if auto-closed by previous window - Removed dialog's handleMessage() related code. No longer needed since JS runs on main UI thread.
build
reviewed
Aug 13, 2019
| * Please see the LICENSE included with this distribution for details. | ||
| */ | ||
| /* eslint-env mocha */ | ||
| /* global Titanium */ |
There was a problem hiding this comment.
⚠️ tests/Resources/ti.ui.android.progressindicator.addontest.js line 8 – 'Titanium' is defined but never used. (no-unused-vars)
|
garymathews
reviewed
Aug 13, 2019
| int thePos = (value - min) * incrementFactor; | ||
|
|
||
| handler.obtainMessage(MSG_PROGRESS, thePos, -1).sendToTarget(); | ||
| int progressValue = (TiConvert.toInt(newValue) - this.min) * this.incrementFactor; |
There was a problem hiding this comment.
Set default to zero?
TiConvert.toInt(newValue, 0)There was a problem hiding this comment.
Yeah, I'll do that. Especially since we're doing this when opening the dialog too.
|
FR Passed. The progress indicator works as expected. |
rlustemberg
added a commit
to inzdr/titanium_mobile
that referenced
this pull request
Sep 20, 2019
* 8_1_X: chore(release): bump version chore(8_1_X): update aps-analytics (tidev#11179) fix(ios): console and tiapi multiple parameter log (tidev#11162) fix(ios): use device build as base for universal module framework (tidev#11120) fix(ios)(8_1_X): properly load watchsession module (tidev#11174) fix(ios): remove invalid architecture from framework for adhoc build (tidev#11087) refactor(android)(8_1_X): ProgressIndicator dialog handling (tidev#11142) refactor(android): consolidate incremental build fixes back into task (tidev#10997)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
Cherry-pick of PR: #11115