Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_3_X): Resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app #11145

Merged
merged 2 commits into from Aug 20, 2019
Merged

fix(android)(8_3_X): Resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app #11145

merged 2 commits into from Aug 20, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway
fix(android): Resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can …
ee3bbf4 
…hang the app

- Modified to effectively restart the app when the following intent flags are set:
  * FLAG_ACTIVITY_MULTIPLE_TASK
  * FLAG_ACTIVITY_NEW_DOCUMENT
- Modified resume code to use main/launch intent flags.
  * We don't want flags such as FLAG_ACTIVITY_CLEAR_TOP to destroy child activities when resuming app.
@jquick-axway
fix(android): Updated code comments for [TIMOB-27271] change
66c6f56
@jquick-axway jquick-axway added this to the 8.3.0 milestone Aug 14, 2019
@build build requested a review from a team August 14, 2019 02:11
@build
Copy link
Contributor

build commented Aug 14, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit ee3bbf4e0e8cba5f288b2c82889d96d47228d6fc has a message "fix(android): Resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app

  • Modified to effectively restart the app when the following intent flags are set:
    • FLAG_ACTIVITY_MULTIPLE_TASK
    • FLAG_ACTIVITY_NEW_DOCUMENT
  • Modified resume code to use main/launch intent flags.
    • We don't want flags such as FLAG_ACTIVITY_CLEAR_TOP to destroy child activities when resuming app." giving 2 errors:
  • header must not be longer than 72 characters, current length is 81
  • subject must not be sentence-case, start-case, pascal-case, upper-case
⚠️

Commit 66c6f563c905b5677d741434d6229a5e4531d239 has a message "fix(android): Updated code comments for [TIMOB-27271] change" giving 1 errors:

  • subject must not be sentence-case, start-case, pascal-case, upper-case
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 1 tests have failed There are 1 tests failing and 472 skipped out of 4328 total tests.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Tests:

ClassnameNameTimeError
ios.Titanium.UI.WebViewuserAgent30.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/40E59782-2B7D-452A-8BED-BB2F68E924F9/data/Containers/Bundle/Application/F1127419-BBEE-463E-B39E-A70D883F7D5D/mocha.app/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against 66c6f56

@keerthi1032
Copy link
Contributor

FR passed.
Test Environment:
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 8.9.0
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.3.0.v20190813185317
device -samsung s5 android 6
Emulator - pixel android 9

garymathews
garymathews approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@keerthi1032
Copy link
Contributor

iOS unit tests failed. Not able to merge PR. @jquick-axway can you please resolve the Jenkins failure and merge PR

@sgtcoolguy sgtcoolguy merged commit 632c439 into tidev:8_3_X Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @keerthi1032 @garymathews @sgtcoolguy