Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android)(8_3_X): compile using SDK 29 #11154

Merged
merged 2 commits into from Aug 20, 2019
Merged

chore(android)(8_3_X): compile using SDK 29 #11154

merged 2 commits into from Aug 20, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Aug 15, 2019 •
edited

  • Update android/package.json to compile using API 29
  • Update Android Studio project files to target Android Q
  • Update TitaniumTest project to target Android Q

TIMOB-26950

@build build added this to the 8.3.0 milestone Aug 15, 2019
@build
Copy link
Contributor

build commented Aug 15, 2019 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4328 tests are passing.
(There are 472 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against c65a0b0

@garymathews
Copy link
Contributor Author

@sgtcoolguy We need to update Jenkins to support this

jquick-axway
jquick-axway suggested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the DEFAULT_API_LEVEL constant to 29 here...
https://github.com/appcelerator/titanium_mobile/blob/8_3_X/build/lib/android/androidsdk.js

We should also update the following "AndroidManifest.xml" files to target 29 as well...
https://github.com/appcelerator/titanium_mobile/blob/8_3_X/android/modules/android/AndroidManifest.xml
https://github.com/appcelerator/titanium_mobile/blob/8_3_X/android/modules/ui/AndroidManifest.xml
https://github.com/appcelerator/titanium_mobile/blob/8_3_X/android/titanium/AndroidManifest.xml

android/package.json Outdated Show resolved Hide resolved
@garymathews garymathews force-pushed the TIMOB-26950 branch 2 times, most recently from 27166f0 to 69a6a9a Compare August 16, 2019 17:17
@tidev tidev deleted a comment from build Aug 16, 2019
@garymathews garymathews changed the title chore(android)(8_3_X): target Android Q 29 chore(android)(8_3_X): compile using SDK 29 Aug 16, 2019
jquick-axway
jquick-axway approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@tidev tidev deleted a comment from build Aug 16, 2019
@sgtcoolguy
Copy link
Contributor

Android 29 (as well as NDK r20, and android 29 emulator using google play services image) is currently rolling out to all our android sdk/ndk build nodes: https://jenkins.appcelerator.org/job/jenkins/job/jenkins/job/master/158/

This PR should be good to rebuild soon...

@garymathews
Copy link
Contributor Author

Yay, it's passing!

@sgtcoolguy sgtcoolguy merged commit 20ae5fd into tidev:8_3_X Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android improvement no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @sgtcoolguy @jquick-axway