Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix reusing a dialog with a new "parent" window (8_3_X) #11156

Merged
merged 1 commit into from Aug 19, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Aug 19, 2019

(cherry picked from commit 62a46fb)

JIRA: https://jira.appcelerator.org/browse/TIMOB-27256

Description:
Backport of: #11073

@ypbnv ypbnv added this to the 8.3.0 milestone Aug 19, 2019
@build build requested a review from a team August 19, 2019 14:45
@build
Copy link
Contributor

build commented Aug 19, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4295 tests are passing.
(There are 472 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against bbed241

@ssekhri
Copy link

ssekhri commented Aug 19, 2019

FR Passed. Dialog re-use works successfully.
Verified on:
Mac OS 10.14.6
Ti SDK: 8.3.0.v20190819072433
Appc CLI: 7.1.1-master.2
Node: 8.16.0
JDK: 10.0.2
Xcode: 10.3
Studio: 5.1.3.201907112159

@ssekhri ssekhri merged commit a8d06c3 into tidev:8_3_X Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants