Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix asset encryption on windows 32bit java (8_3_X) #11159

Merged
merged 2 commits into from Aug 20, 2019

Conversation

ewanharris
Copy link
Collaborator

@ewanharris ewanharris changed the title fix(android): fix asset encryption on windows 32bit java fix(android): fix asset encryption on windows 32bit java (8_3_X) Aug 19, 2019
@build build added this to the 8.3.0 milestone Aug 19, 2019
@build
Copy link
Contributor

build commented Aug 19, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 1 tests have failed There are 1 tests failing and 472 skipped out of 4328 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
ios.Titanium.Database#executeAllAsync() does not allow DB to be GC'd120.007
Error: timeout of 120000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/29E1514E-93D8-4A4B-A306-F232955340BA/data/Containers/Bundle/Application/BAFFF6EE-9D47-4EB9-AC88-F0AD99A866AE/mocha.app/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against 1deb96e

@garymathews
Copy link
Contributor

titanium_prep is going away in 8_3_X 😄

@ewanharris
Copy link
Collaborator Author

ewanharris commented Aug 20, 2019

@garymathews, so shall I close this PR?

Edit:

Actually I think we'll still want to merge right? 8_3_X will eventually get merged back to master so we wanna make sure that things line up correctly?

@ssjsamir ssjsamir self-requested a review August 20, 2019 10:35
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to build to Android device now providing the following are followed: https://jira.appcelerator.org/browse/TIMOB-27266?focusedCommentId=450601&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-450601

Test Environment

Operating System
Name = Microsoft Windows 10 Pro
Version = 10.0.18362
Architecture = 64bit

CPUs = 4
Memory = 32.0GB
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1

Appcelerator CLI
Core Package = 7.1.0-master.24

Titanium CLI
CLI Version = 5.2.1
node-appc Version = 0.2.49

@sgtcoolguy sgtcoolguy merged commit 19403ec into tidev:8_3_X Aug 20, 2019
@ewanharris ewanharris deleted the TIMOB-2726683X branch August 31, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants