Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios)(8_1_X): console and tiapi multiple parameter log #11162

Merged
merged 5 commits into from Aug 28, 2019
Merged

fix(ios)(8_1_X): console and tiapi multiple parameter log #11162

merged 5 commits into from Aug 28, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway changed the title fix(ios): console and tiapi multiple parameter log fix(ios)(8_1_X): console and tiapi multiple parameter log Aug 21, 2019
@build build added this to the 8.1.1 milestone Aug 21, 2019
@build build requested a review from a team August 21, 2019 22:25
@build
Copy link
Contributor

build commented Aug 21, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3738 tests are passing.
(There are 470 tests skipped)

Generated by 🚫 dangerJS against aadc6b4

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Aug 23, 2019 •
edited

FR Passed.

Checked with the test code. Runs as expected.

Studio Ver: 5.1.3.201907112159
SDK Ver: 8.1.1 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.0
Appc NPM: 4.2.15-1
Appc CLI: 7.1.1-5
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.1
Alloy Ver: 1.14.1
Node Ver: 10.16.1
NPM Ver: 6.9.0
Java Ver: 10.0.2
Device: Iphone 7 IOS 12
Simulator: Iphone XR ios 13

sgtcoolguy
sgtcoolguy suggested changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is crashing on our test suite where we explicitly try logging undefined (the value, not the string). null/undefined are not being properly handled and your attempting to insert it into an NSArray (as nil on the Obj-c side).

@sgtcoolguy sgtcoolguy merged commit 3ec42b5 into tidev:8_1_X Aug 28, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Sep 20, 2019
@rlustemberg
Merge branch '8_1_X' into 8_1_X_INZDR
ecfe688 
* 8_1_X:
  chore(release): bump version
  chore(8_1_X): update aps-analytics (tidev#11179)
  fix(ios): console and tiapi multiple parameter log (tidev#11162)
  fix(ios): use device build as base for universal module framework (tidev#11120)
  fix(ios)(8_1_X): properly load watchsession module (tidev#11174)
  fix(ios): remove invalid architecture from framework for adhoc build (tidev#11087)
  refactor(android)(8_1_X): ProgressIndicator dialog handling (tidev#11142)
  refactor(android): consolidate incremental build fixes back into task (tidev#10997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy requested changes

Assignees
No one assigned
Labels
bug ios no tests
Projects
None yet
Milestone
8.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @lokeshchdhry @sgtcoolguy