Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fallback to non-widget require in catch (8_3_X) #11167

Merged
merged 2 commits into from Aug 29, 2019

Conversation

ewanharris
Copy link
Collaborator

Fixes TIMOB-27195

JIRA: https://jira.appcelerator.org/browse/TIMOB-27195

8_3_X backport for #11008

@build build added this to the 8.3.0 milestone Aug 22, 2019
@build build requested a review from a team August 22, 2019 15:03
@build
Copy link
Contributor

build commented Aug 22, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4350 tests are passing.
(There are 472 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 4239124

This ensures that when the alloy require fails we try the normal require

Fixes TIMOB-27195
@sgtcoolguy sgtcoolguy merged commit 22f7f88 into tidev:8_3_X Aug 29, 2019
@ewanharris ewanharris deleted the TIMOB-2719583x branch August 31, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants