Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): prevents TabGroup duplicate close event firing (8_3_X) #11175

Closed
wants to merge 5 commits into from

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Aug 26, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27118

Description:
Backport for: #11062
(cherry picked from commit f2e94af)

jquick-axway and others added 5 commits August 20, 2019 13:04
…idev#11141)

Fixed bug where opening a window while splash is in mid-transition causes splash to adopt child window's transition. Causes noticeable stutter.
  * Especially an issue as of Android Q beta 4.
  * Modified so that activity windows launched from splash override pending transition with fade-in transition instead. (Looks better than slide-up animation anyways.)

Fixes TIMOB-27328
- Fixed so that Android setting <uses-feature/> required "true" in "tiapp.xml" should override "false" setting in libraries.
  * Merge is supposed to do a logical-OR on the "android:required" value.
- Added "tools:replace" attribute support to <uses-feature/>.
  * Allows overriding "android:required" to "false" if set "true" by library. (Only means of doing this.)

Fixes TIMOB-27304
* [TIMOB-27104] ProgressIndicator logs "WindowLeaked" exception when hiding dialog and closing window at same time as of 8.0.2
* [TIMOB-27308] Determinant ProgressIndicator ignores "value" property before shown
* [TIMOB-27309] Cannot re-show ProgressIndicator dialog if auto-closed by previous window
* Removed dialog's handleMessage() related code. No longer needed since JS runs on main UI thread.
* added unit test for Ti.UI.Android.ProgressIndicator

Fixes TIMOB-27104, TIMOB-27308, TIMOB-27309
@ypbnv ypbnv added this to the 8.3.0 milestone Aug 26, 2019
@ypbnv ypbnv requested a review from garymathews August 26, 2019 14:12
@build build requested a review from a team August 26, 2019 14:41
@build
Copy link
Contributor

build commented Aug 26, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

✅ All tests are passing
Nice one! All 2108 tests are passing.
(There are 245 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 402ca5a

@sgtcoolguy sgtcoolguy changed the base branch from 8_3_X to master September 9, 2019 18:04
@sgtcoolguy
Copy link
Contributor

Closing as master is now 8.3.0 target, so #11062 is sufficient to land for 8.3.0

@sgtcoolguy sgtcoolguy closed this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants