Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(8_3_X): update aps-analytics #11180

Merged
merged 4 commits into from Aug 29, 2019
Merged

chore(8_3_X): update aps-analytics #11180

merged 4 commits into from Aug 29, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Aug 26, 2019 •
edited

  • Update aps-analytics for both iOS and Android
    • Improve event batching
  • Improve unhandled exception stack traces
  • Parse new Date object correctly when sending as event data

JIRA Ticket

@garymathews garymathews added this to the 8.3.0 milestone Aug 26, 2019
@build
Copy link
Contributor

build commented Aug 26, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4350 tests are passing.
(There are 472 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against f6a172d

@build build requested a review from a team August 27, 2019 00:19
@lokeshchdhry
Copy link
Contributor

FR Passed.

Checked with test here https://gist.github.com/garymathews/0170fecd310936f1c8030651bb5aed0e

Studio Ver: 5.1.3.201907112159
SDK Ver: 8.3.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.0
Appc NPM: 4.2.15-1
Appc CLI: 7.1.1-5
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.1
Alloy Ver: 1.14.1
Node Ver: 10.16.1
NPM Ver: 6.9.0
Java Ver: 10.0.2
Android Devices: ⇨ google Pixel (Android 9)
IOS Devices: ⇨ iPhone 12.4
ACA : 1.4.0 (pre release)

@lokeshchdhry
Copy link
Contributor

FR passed after review.

@lokeshchdhry lokeshchdhry merged commit b8d255b into tidev:8_3_X Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @lokeshchdhry