New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): fix table view row width ti.ui.size height #11187
Conversation
Fixes TableView rows with height set to Ti.UI.SIZE not returning their 'rect' properly and not respecting children resizing.
row = Ti.UI.createTableViewRow({ width: Ti.UI.FILL, height: Ti.UI.SIZE }), | ||
view = Ti.UI.createView({ height: 150 }); | ||
row.add(view); | ||
table.setData([row]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.tableview.addontest.js line 35 – A space is required after '['. (array-bracket-spacing)⚠️ tests/Resources/ti.ui.tableview.addontest.js line 35 – A space is required before ']'. (array-bracket-spacing)
Tests:
|
Hi @ypbnv. IIRC the actual problem with Also there was fix for NullPointerException in my PR. |
row = Ti.UI.createTableViewRow({ width: Ti.UI.FILL, height: Ti.UI.SIZE }), | ||
view = Ti.UI.createView({ height: 150 }); | ||
row.add(view); | ||
table.setData([row]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.tableview.addontest.js line 20 – A space is required after '['. (array-bracket-spacing)⚠️ tests/Resources/ti.ui.tableview.addontest.js line 20 – A space is required before ']'. (array-bracket-spacing)
Closing in favour of #10542 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26662
Description:
Fixes TableView rows with height set to Ti.UI.SIZE not returning their 'rect' properly and not
respecting children resizing.
I see the iOS is failing the unit tests. Would this behavior be expected on that platform?
Test case:
app.js