New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): remove old UIWebView left overs #11190
Conversation
|
@janvennemann @sgtcoolguy Please allow me to argue that this change does not require unit tests and should therefore receive the |
Agreed on the no tests label! The only thing QE could test is to submit an app to make sure the deprecation note is gone. cc @lokeshchdhry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR passed: Not getting any deprecation errors when building to the app store.
Test Environment
MacOS Mojave version 10.14.4
Xcode 10.2.1
Xcode 11 beta 5
Node.js ^8.11.1
"NPM":"4.2.14","CLI":"7.1.1-master.2"
JIRA: https://jira.appcelerator.org/browse/TIMOB-27367
Suggesting to merge at the earliest possible time so users won't be affected by this when it becomes serious.