Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(8_3_X) fix(ios): remove old UIWebView left overs #11191

Merged
merged 1 commit into from Sep 4, 2019
Merged

(8_3_X) fix(ios): remove old UIWebView left overs #11191

merged 1 commit into from Sep 4, 2019

Conversation

hansemannn
Copy link
Collaborator

@build build added this to the 8.3.0 milestone Aug 30, 2019
@build build requested review from a team August 30, 2019 11:50
@build
Copy link
Contributor

build commented Aug 30, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

✅ All tests are passing
Nice one! All 4350 tests are passing.
(There are 472 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 49465e6

@ssjsamir ssjsamir self-requested a review September 4, 2019 10:58
ssjsamir
ssjsamir approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed: Not getting any deprecation errors when building to the app store.

Test Environment

MacOS Mojave version 10.14.4
Xcode 10.2.1
Xcode 11 beta 5
Node.js ^8.11.1
"NPM":"4.2.14","CLI":"7.1.1-master.2"

@ssjsamir ssjsamir merged commit fdf042a into tidev:8_3_X Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
community 🔥 docs in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @janvennemann @ssjsamir