New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr(android): implement TLSv3 support #11195
Conversation
|
8c43a88
to
e3b0825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test that automates the exact test case you pasted in manually.
/* eslint-env mocha */ | ||
/* eslint no-unused-expressions: "off" */ | ||
'use strict'; | ||
var should = require('./utilities/assertions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.network.httpclient.addontest.js line 10 – 'should' is assigned a value but never used. (no-unused-vars)
a30e262
to
53ac089
Compare
daa6464
to
164f4ce
Compare
} | ||
}, | ||
onerror: | ||
e => { finish(new Error('Could not determine TLSv3 support.')); }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.network.httpclient.addontest.js line 29 – 'e' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)
@garymathews, maybe we should add the The rest of your changes look fine. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
f00f80f
to
091cfb1
Compare
FR Passed. |
TLSv3
support intoTitanium.Network
TEST CASE
JIRA Ticket