fix(ios): update tabbar after trait colection changed

[vijaysingh-axway]

https://jira.appcelerator.org/browse/TIMOB-27126

[build]

	Fails
🚫	Tests have failed, see below for more information.

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	❌ 1 tests have failed There are 1 tests failing and 472 skipped out of 4380 total tests.
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

Classname	Name	Time	Error
ios.os	#hostname() returns Ti.Platform.address value	0	Error: expected '' to equal undefined fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/node_modules/should/cjs/should.js:275:23 value@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/node_modules/should/cjs/should.js:356:23 file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/os.test.js:123:31 file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4376:41 file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4763:17 file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4840:23 next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4688:20 file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4698:15 next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4636:30 file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:4665:13 timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/1EC718C0-E2D8-4CAC-8666-34B08BA5B5C4/mocha.app/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against 8fd9819

[keerthi1032]

FR passed. tab group image changes concurrently when mode changes on iOS 13.

Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.2.0.v20190906123526
Device =iPhone XR iOS 13
Simulator -iPhone 8 iOS 13

[hansemannn]

Shouldn't the UIImage instances use semantic images already and check automatically?

[vijaysingh-axway]

There seems a bug from apple side. See https://stackoverflow.com/questions/57011346/uitabbar-uitabbaritem-and-ios-13s-dark-mode

[hansemannn]

Okay. But traitCollectionDidChange: fires for iOS 8+ and also if the device is rotated or font scaling is updated. It's minor but should be guarded in a later release to prevent unnecessary UI work.