Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): allow requestLegacyExternalStorage attribute #11205

Merged
merged 4 commits into from Sep 16, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Sep 9, 2019

  • Add requestLegacyExternalStorage to attributes

JIRA Ticket

Test:

  1. Create a Classic Titanium project.
  2. Add the below <application/> element to the project's "tiapp.xml" file.
  3. Build for Android.
  4. In Finder (or Windows Explorer) go to project folder: ./build/android
  5. Open the "AndroidManifest.xml" file.
  6. Verify that the <application/> element has attribute android:requestLegacyExternalStorage="true".
<?xml version="1.0" encoding="UTF-8"?>
<ti:app xmlns:ti="http://ti.appcelerator.org">
	<android xmlns:android="http://schemas.android.com/apk/res/android">
		<manifest>
			<application android:requestLegacyExternalStorage="true"/>
		</manifest>
	</android>
</ti:app>

@build
Copy link
Contributor

build commented Sep 9, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4334 tests are passing.
(There are 471 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against ec6209c

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@keerthi1032
Copy link
Contributor

FR passed.LegacyExternalStorage attribute is added.

Test Environment:
Name = Mac OS X
Version = 10.14.6
Architecture = 64bit
Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version =Local sdk 8.3.0.v20190909124736
Device -Samsung s5 android 6
Emulator- pixel android q, pixel 3xl android 8

@keerthi1032 keerthi1032 merged commit 097c5af into tidev:master Sep 16, 2019
drauggres pushed a commit to drauggres/titanium_mobile that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants